Fix: calfw-org: Ensure that string-match does not get nil input #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the following customization:
```elisp
(setq cfw:org-agenda-schedule-args
'(:deadline :scheduled :timestamp))
```
`M-x cfw:open-org-calendar` fails to render. This happens because the
functions `cfw:org-summary-format` and `cfw:org-get-timerange` do not
guard against text properties being nil when calling `string-match`.
This commit adds the guard, which leads to the calendar rendering
correctly.
vedang
added a commit
to vedang/calfw-blocks
that referenced
this pull request
Jan 21, 2023
`string-match` cannot handle nil. Adding this guard allows calfw to work correctly again. A similar fix is needed in `emacs-calfw` as well and has been contributed at kiwanami/emacs-calfw#155.
vedang
added a commit
to vedang/emacs-up
that referenced
this pull request
Jan 23, 2023
Visually looking at the day gives a far more visceral understanding of what you plan to do today. Note that I am using personal recipes for both these projects, until the fixes I've made can be merged upstream. The relevant PRs are: - kiwanami/emacs-calfw#154 - kiwanami/emacs-calfw#155 - ml729/calfw-blocks#1 - ml729/calfw-blocks#2
|
Thank you, this PR fixed an issue that recently started happening where I'd get an error when trying to open the calfw calendar. 👍 I do not have the customization you mentioned (the variable is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following customization:
M-x cfw:open-org-calendarfails to render. This happens because the functionscfw:org-summary-formatandcfw:org-get-timerangedo not guard against text properties being nil when callingstring-match.This commit adds the guard, which leads to the calendar rendering correctly.